hardware: cache GPIO mount paths on load to avoid blocking stat#6855
Open
agners wants to merge 1 commit into
Open
hardware: cache GPIO mount paths on load to avoid blocking stat#6855agners wants to merge 1 commit into
agners wants to merge 1 commit into
Conversation
Building the app container mount list called Path.exists() on candidate GPIO sysfs paths from the event loop, which blockbuster flagged as a blocking os.stat. Whether these sysfs paths exist is determined by the kernel at boot and does not change at runtime, so resolve them once in HwHelper.load() (invoked from HardwareManager.load()) and expose the result via helper.gpio_mount_paths. DockerApp.mounts can then stay a plain sync property. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Member
Author
|
Fixes the following Blockbuster exception: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Building the app container mount list called
Path.exists()on candidate GPIO sysfs paths (/sys/class/gpio,/sys/devices/platform/soc) from insideDockerApp.mounts, which is invoked on the event loop. With blockbuster enabled (ha su options --detect-blocking-io on) starting the Advanced SSH & Web Terminal add-on raisedBlockingError: Blocking call to os.stat, e.g.:Whether these sysfs paths exist is determined by the kernel at boot and does not change at runtime. Resolve them once in a new
HwHelper.load()(invoked fromHardwareManager.load()) and expose the result viahelper.gpio_mount_paths.DockerApp.mountsstays a plain sync property and just iterates the cached tuple.Type of change
Additional information
Checklist
ruff format supervisor tests)If API endpoints or add-on configuration are added/changed: